plule / vox-uristi

Vox Uristi exports Dwarf Fortress maps to MagicaVoxel
https://plule.github.io/vox-uristi/
GNU General Public License v3.0
26 stars 0 forks source link

Top `Current` elevation button excludes top layer #1

Closed TaxiService closed 1 year ago

TaxiService commented 1 year ago

Hi! Like, i encountered a behaviour i consider unexpected.

When setting the elevation range, the top layer (the one you are looking at when you click the Current button) is excluded from the exported file.

Like, i would have expected it to be included. :p

luckily i was able to record a webm of this within 10 MB 🤣

MagicaVoxel_S4Fpc3HasA.webm

as you can see, like, the top layer is missing from the model. If i go back in game, go down 1 layer, and click "Current" again, the elevation is lowered by one.

I mean-- this is totally a minor issue, i can easily work around it by going one level higher before exporting, but i think it is a bit counter-intuitive. This could probably be fixed just as easily by changing a > to a >= somewhere, i guess? i mean, if you think this is a problem!

plule commented 1 year ago

Yep, that was intended but it makes much more sense to include it, thank you for the suggestion