search

plumatic / dommy

A tiny ClojureScript DOM manipulation and event library
759 stars 74 forks source link

Allow nil #15

Closed aiba closed 11 years ago

aiba commented 11 years ago

This change will ignore nil elements in templates instead of throwing an error. This is useful if you want to put (when) clauses directly in a template, and matches the behavior of hiccup.core/html.

mpenet commented 11 years ago

+1

I need this as well.

dubiousdavid commented 11 years ago

Is this still an issue?

mpenet commented 11 years ago

My guess is yes, since it hasn't been merged. I don't think the previous PR fixes that but I didn't test it.

dubiousdavid commented 11 years ago

It's still broken.

Uncaught Don't know how to make node from: nil

On Mar 21, 2013, at 4:10 PM, Max Penet notifications@github.com wrote:

My guess is yes, since it hasn't been merged. I don't think the previous PR fixes that but I didn't test it.

— Reply to this email directly or view it on GitHub.

aria42 commented 11 years ago

Sorry we're really slammed right now, we do have this fixed internally and will release a fix along with some other new features soon.

dubiousdavid commented 11 years ago

Cool. I'm just starting my first ClojureScript project, and currently figuring out all the libraries I'll need :)

mpenet commented 11 years ago

I put a patched version on clojars in case you need it now (I do). https://clojars.org/cc.qbits/dommy (matches this branch https://github.com/mpenet/dommy/tree/patched )

mpenet commented 11 years ago

By the way that made me notice: the versioning # are a bit odd, I don't know if you follow semver, but 0.0.3 should be 0.3.0 instead probably.

simon-nicholls commented 11 years ago

Thanks, Max.

dubiousdavid commented 11 years ago

I know you guys are busy, but this was opened a month ago. Seems like this should have been merged by now.

aria42 commented 11 years ago

We're just about to push an update (1-2 days) that fixes this guy and does many more things

Sent from my iPhone

On Apr 1, 2013, at 8:01 AM, David Sargeant notifications@github.com wrote:

I know you guys are busy, but this was opened a month ago. Seems like this should have been merged by now.

— Reply to this email directly or view it on GitHub.

dubiousdavid commented 11 years ago

Awesome. Looking forward to it!

On Apr 1, 2013, at 11:47 AM, Aria Haghighi notifications@github.com wrote:

We're just about to push an update (1-2 days) that fixes this guy and does many more things

Sent from my iPhone

On Apr 1, 2013, at 8:01 AM, David Sargeant notifications@github.com wrote:

I know you guys are busy, but this was opened a month ago. Seems like this should have been merged by now.

— Reply to this email directly or view it on GitHub. — Reply to this email directly or view it on GitHub.

aria42 commented 11 years ago

I believe this has now been fixed and your test case merged in with our changes. We had a concurrent set of changes to the actual templating stuff but your test case was still useful. Thanks and sorry that took so long.