search

plumatic / dommy

A tiny ClojureScript DOM manipulation and event library
759 stars 74 forks source link

show! doesn't work on elements hidden by CSS #38

Closed JulianBirch closed 10 years ago

JulianBirch commented 11 years ago

Because it sets the style display to blank, which effectively means revert to original.

This is what zepto does, so is arguably not a bug.

aria42 commented 11 years ago

I don't think this is a bug either. I'm not sure what I good alternative would look like?

JulianBirch commented 11 years ago

Well, I suspect that the only alternative is what jQuery does

https://github.com/jquery/jquery/blob/master/src/css.js#L56

This means a) having a general css query syntax b) keeping track of which elements default to which styles c) keeping track for the former display style of elements that have been hidden.

But it's an awful lot of work for an edge-case.