Valid ids are not recognized by sel

plumatic / dommy

A tiny ClojureScript DOM manipulation and event library

759 stars 74 forks source link

Valid ids are not recognized by sel #48

Closed jeluard closed 10 years ago

jeluard commented 10 years ago

Some valid ids (e.g. containing .) are not recognized by sel.

According to html 4 spec : and . are valid id character. html 5 relaxes that to any unicode character.

jeluard commented 10 years ago

Is that something you would consider a PR for?

aria42 commented 10 years ago

Yes. Definitely would.

jeluard commented 10 years ago

I didn't realized that hiccup used . as id/class separator. Although sel could be modified to support . in id it would introduced some asymmetry. Probably not worth the confusion.