search

plumatic / dommy

A tiny ClojureScript DOM manipulation and event library
760 stars 73 forks source link

Fix tests in firefox #72

Closed koddsson closed 10 years ago

koddsson commented 10 years ago

These patches fix the four failing tests when running the test suite in firefox and should make dommy not fail on some features when running in firefox.

cpetzold commented 10 years ago

Looks great, thanks! :+1:

cpetzold commented 10 years ago

Hmm, I should have caught this earlier, but the functions that rely on style are assuming the computed style (via getComputedStyle), not style which is only explicitly added styles.

I reverted the change and added the referenced ticket for this issue specifically.

I'm open to another patch, but will look in to this soon as well. The other recent change was moving over to clojurescript.test with just a phantomjs runner, so I'll need to add the html runner back so we can still test in FF.

Thanks again.