search

plumatic / dommy

A tiny ClojureScript DOM manipulation and event library
759 stars 73 forks source link

Fix for #68 #73

Closed jeluard closed 9 years ago

jeluard commented 10 years ago

PR updated. I also now correctly dissoc is when needed.

cpetzold commented 10 years ago

Looks good! Can you write a simple test?

jeluard commented 10 years ago

Not quite sure what I could test here. Maybe that the prototype is correct?

Also tests could not run with phantomjs as it does not yet support this feature, unless a polyfill is injected in the runner.

jeluard commented 10 years ago

It seems the final API name is still not fixed so it's worth waiting some more time.

cpetzold commented 10 years ago

Okay sounds good. Going forward I'm going to try and be more meticulous about maintaining a certain level of browser compatibility. I think supporting everything that's not IE<9 should be reasonable.

Features like this are probably okay because they're not adding functions to the main api that are specific to only some browsers..

jeluard commented 10 years ago

Makes sense.

In this case I believe it is safe as the presence of the previously unused is attribute triggers a different call.

jeluard commented 9 years ago

Now integrated in hipo library.