Fix "Wrong number of args" warning in cljs.

plumatic / schema

Clojure(Script) library for declarative data description and validation

Other

2.4k stars 256 forks source link

Fix "Wrong number of args" warning in cljs. #418

Closed chadharrington closed 5 years ago

chadharrington commented 5 years ago

This PR fixes a "Wrong number of args" warning in cljs. You can see the warning in the attached screenshot (shadow-cljs output):

Specifically, the fix calls the MapEntry constructor with the required third __hash arg. The cljs docs specify that the constructor takes 3 arguments: https://cljs.github.io/api/cljs.core/MapEntry

Merging this tiny PR will make our build output a lot less noisy!

Thank you for your good work on this project.

mynomoto commented 5 years ago

I got the same warning and was cloning the repo to do a PR when I found this. This would be really nice for cljs users.

gfredericks commented 5 years ago

Looks good, thanks!

gfredericks commented 5 years ago

I'd like to fix #416 and then release both of these together, but I can release just this if I don't get around to the other one.

chadharrington commented 5 years ago

Thanks, Gary!

w01fe commented 5 years ago

👍

gfredericks commented 5 years ago

Released as 1.1.12.

chadharrington commented 5 years ago

Thanks!