plumatic / schema

Clojure(Script) library for declarative data description and validation
Other
2.4k stars 256 forks source link

JSC_BAD_JSDOC_ANNOTATION warnings #449

Closed metametadata closed 1 year ago

metametadata commented 1 year ago

After bumping from 1.3.5 to 1.4.0 we get novel warnings on advanced compilation:

Figwheel] Compiling build min to "resources/public/js/spa.js"
Compile sources, elapsed time: 17187.595841 msecs
Compile sources, elapsed time: 27.624681 msecs
Sept 23, 2022 9:50:09 PM com.google.javascript.jscomp.LoggerErrorManager println
WARNING: .../spa/target/public/cljs-out/min/schema/core.js:7105:9: WARNING - [JSC_BAD_JSDOC_ANNOTATION] Parse error. illegal use of unknown JSDoc tag ""; ignoring it. Place another character before the @ to stop JSCompiler from parsing it as an annotation.
  7105|  *   *   @*elide-defprotocol-instrumentation* is true during s/defprotocol macroexpansion
                 ^

Sept 23, 2022 9:50:09 PM com.google.javascript.jscomp.LoggerErrorManager println
WARNING: .../spa/target/public/cljs-out/min/schema/core.js:7106:9: WARNING - [JSC_BAD_JSDOC_ANNOTATION] Parse error. illegal use of unknown JSDoc tag ""; ignoring it. Place another character before the @ to stop JSCompiler from parsing it as an annotation.
  7106|  *   *   @*elide-defprotocol-instrumentation* is true during s/defprotocol evaluation
                 ^

Sept 23, 2022 9:50:09 PM com.google.javascript.jscomp.LoggerErrorManager printSummary
WARNING: 0 error(s), 2 warning(s)
Optimizing with Google Closure Compiler, elapsed time: 19154.404307 msecs
Optimizing 317 sources, elapsed time: 19670.989385 msecs
[Figwheel] Successfully compiled build min to "resources/public/js/spa.js" in 37.62 seconds.
frenchy64 commented 1 year ago

@metametadata thanks for the report! I followed the advice in the error message, can you try 1.4.1 please?

metametadata commented 1 year ago

It compiles as expected now. Thank you!

frenchy64 commented 1 year ago

Please let me know if there's something we can add to the test suite to better exercise this case.