plumdog / flask_table

Because writing HTML is fiddly and all of your tables are basically the same
http://flask-table.readthedocs.org/
BSD 3-Clause "New" or "Revised" License
210 stars 45 forks source link

Markup seems to be deprecated and is now markupsafe apparently #137

Open adamantic opened 1 year ago

adamantic commented 1 year ago

Markup seems to be deprecated and is now markupsafe apparently

File "/app/.heroku/python/lib/python3.9/site-packages/flask_table/init.py", line 1, in 2023-10-03T10:46:35.754301+00:00 app[web.1]: from .table import Table, create_table 2023-10-03T10:46:35.754301+00:00 app[web.1]: File "/app/.heroku/python/lib/python3.9/site-packages/flask_table/table.py", line 5, in 2023-10-03T10:46:35.754301+00:00 app[web.1]: from flask import Markup 2023-10-03T10:46:35.754301+00:00 app[web.1]: ImportError: cannot import name 'Markup' from 'flask' (/app/.heroku/python/lib/python3.9/site-packages/flask/init.py)

mikehooper commented 12 months ago

I've got the same issue:

File "/home/pi/uvrobot/main.py", line 8, in from tables import Results, SubSections File "/home/pi/uvrobot/tables.py", line 1, in from flask_table import Table, Col, LinkCol File "/home/pi/uvrobot/env/lib/python3.11/site-packages/flask_table/init.py", line 1, in from .table import Table, create_table File "/home/pi/uvrobot/env/lib/python3.11/site-packages/flask_table/table.py", line 5, in from flask import Markup ImportError: cannot import name 'Markup' from 'flask' (/home/pi/uvrobot/env/lib/python3.11/site-packages/flask/init.py)

jbhanks commented 12 months ago

Same. I just patched it manually on my installation, but it would be nice to get it fixed in the repos.

gmassman commented 10 months ago

I opened PR #141 to fix this issue, waiting on approval from @plumdog.

jbhanks commented 9 months ago

I opened PR #141 to fix this issue, waiting on approval from @plumdog.

I hope it gets merged soon, it's annoying to have a custom patch as part of my installation scripts. It's a one-line change, has @plumdog given up on this project? If so, should it be forked and submitted to PyPi as a replacement?

charlesmartin14 commented 7 months ago

I alo have this problem

yaalaa commented 6 months ago

+1 please fix it