search

plume-sig / zk-nullifier-sig

Implementation of PLUME: nullifier friendly signature scheme on ECDSA
MIT License
133 stars 22 forks source link

Incorrect comment on `encode_pt()` #17

Closed 0xbok closed 1 year ago

0xbok commented 1 year ago

https://github.com/plume-sig/zk-nullifier-sig/blob/main/rust-k256/src/lib.rs#L429-L435

encode_pt() is described as:

/// Format a ProjectivePoint to 64 bytes - the concatenation of the x and y values.  We use 64
/// bytes instead of SEC1 encoding as our arkworks secp256k1 implementation doesn't support SEC1
/// encoding yet.

However, it converts a ProjectivePoint to its compressed form of 33 bytes.