plume-sig / zk-nullifier-sig

Implementation of PLUME: nullifier friendly signature scheme on ECDSA
MIT License
129 stars 22 forks source link

The method "wallet_enable" does not exist / is not available. #28

Open critesjosh opened 1 year ago

critesjosh commented 1 year ago

I'm not sure if this is the right repo for this issue, but in the demo app (https://ethbogota-2022.netlify.app/) I see the following error when trying to connect Metamask Flask.

"The method "wallet_enable" does not exist / is not available."

image

Divide-By-0 commented 1 year ago

Piotr: this method was deprecated and replaced by wallet_request

It should be a pretty easy change, thanks for the catch!

Divide-By-0 commented 9 months ago

Metamask snaps has now disabled support for PLUMEs by blocking access to private key exponentiation, which is a perfectly safe API to have (i.e. Ledger wallets give access to this to external parties) and does NOT leak the secret key. We are shifting focus to Taho wallet and Ledger instead.

critesjosh commented 9 months ago

That's a bummer. Any idea why they blocked access?

Divide-By-0 commented 9 months ago

I have no idea to be honest. We used to be able to request private key entropy directly which was arguably a bad api, so it makes sense they removed that. I would guess there aren't many cryptographers on their team; allowing g^sk is a fairly niche thing only really used by new signature schemes like us to be fair.