search

plume-sig / zk-nullifier-sig

Implementation of PLUME: nullifier friendly signature scheme on ECDSA
MIT License
129 stars 22 forks source link

Document npm install workaround #29

Closed BlakeMScurr closed 10 months ago

BlakeMScurr commented 1 year ago

We depend on better-sqlite3@7.6.2, which has a build issue which can be worked around as described.

better-sqlite is not actually needed, it's just a transitive depedency: secp256k1_hash_to_curve_circom > circom-helper > better-sqlite3@7.6.2

The best solution is to edit secp256k1_hash_to_curve_circom so that we can import the circuits and typescript helpers without also importing the testing infrastructure, which better-sqlite3 is needed for. The workaround should be redundant once the dependencies are fixed.

weijiekoh commented 1 year ago

Hi! Would it be helpful if we moved circom-helper to devDependencies in https://github.com/geometryresearch/secp256k1_hash_to_curve/blob/main/circuits/package.json ?