Closed skaunov closed 10 months ago
Divide-By-0
commented
10 months ago Hey sorry we are depreciating sha512, can you switch this to sha256? I saw it in the comments but c definitely won't be the same across implementations if some are sha512.
skaunov
commented
10 months ago Okay... Will add a commit. Just didn't want to mix root cause of #23 with SHA-2 variant migration. X)
Divide-By-0
commented
10 months ago Oh, got it. Makes sense then. c itself will still be inconsistent, but modulus wont -- I edited that issue title, so can merge this!
Divide-By-0
commented
10 months ago Well one problem on the tests, it fails since
npm ERR! sha512-X7RxH19+hScc5pluCyS+f6P9EcZtJm189LgBqDOI018sP+SGmkFmtUk+Z+km5Go9qYRSLsaU84k/gUlRZGYWVA== integrity checksum failed when using sha512: wanted sha512-X7RxH19+hScc5pluCyS+f6P9EcZtJm189LgBqDOI018sP+SGmkFmtUk+Z+km5Go9qYRSLsaU84k/gUlRZGYWVA== but got sha512-rvEAEILDvmfdBLWtlrU18jajpnRmJKARoaHlcWRYen9QSJvmhTZsGtyLKIetUCjX2lzggy3/HdLJyZpi/v0VuQ==. (143867 bytes)
skaunov
commented
10 months ago Well one problem on the tests, it fails since
npm ERR! sha512-X7RxH19+hScc5pluCyS+f6P9EcZtJm189LgBqDOI018sP+SGmkFmtUk+Z+km5Go9qYRSLsaU84k/gUlRZGYWVA== integrity checksum failed when using sha512: wanted sha512-X7RxH19+hScc5pluCyS+f6P9EcZtJm189LgBqDOI018sP+SGmkFmtUk+Z+km5Go9qYRSLsaU84k/gUlRZGYWVA== but got sha512-rvEAEILDvmfdBLWtlrU18jajpnRmJKARoaHlcWRYen9QSJvmhTZsGtyLKIetUCjX2lzggy3/HdLJyZpi/v0VuQ==. (143867 bytes)
It's the one which runs the suit in <./circuits>, to my shame I don't know how to detach it from this PR. :upside_down_face: I already updated that workflow to scope only <./javascript>. And updated passes! X)
proposed commit message for squashing merge
cswitched to be hash in the cratescconversion to number / field element moved to consuming functions more like it's in <./javascript> now