search

plume-sig / zk-nullifier-sig

Implementation of PLUME: nullifier friendly signature scheme on ECDSA
MIT License
129 stars 22 forks source link

Fix array signals #48

Closed RajeshRk18 closed 9 months ago

RajeshRk18 commented 10 months ago

Fixes #19

RajeshRk18 commented 10 months ago

@Divide-By-0 To run tests, I need to run npm cache clean --force and then run tests. Idk whats the issue. But, the error seems to be like secp256k1_hash_to_curve_circom lib is corrupted. Checksum failed

Divide-By-0 commented 10 months ago

We just patched the lib, see the last commit. You'll need to delete yarn lock and remake. https://github.com/geometryresearch/secp256k1_hash_to_curve

Divide-By-0 commented 10 months ago

Hey -- we have no idea if the changes you made are correct unless we have some test we can use to evaluate the circom circuit. Can you add a circom test via circom-tester to the CI to verify that it's still constrained correctly?

RajeshRk18 commented 10 months ago

Hey -- we have no idea if the changes you made are correct unless we have some test we can use to evaluate the circom circuit. Can you add a circom test via circom-tester to the CI to verify that it's still constrained correctly?

Create an issue to add circom tester to the CI. I will try.

RajeshRk18 commented 10 months ago

I tried running tests in my machine. Most of the time, it gets killed, maybe oom issue idk. Can you help me with this?

Divide-By-0 commented 10 months ago

Yes. Set max workers to 2: https://github.com/zkemail/zk-email-verify/pull/104

Divide-By-0 commented 9 months ago

You can also use circleci or just have the witness generation be the test.

skaunov commented 9 months ago

I suppose @Divide-By-0 reviewed the code, since I only ran the test suite (it's green). And now will be merging, maybe with squashing.

skaunov commented 9 months ago

Merged via #65 due to the branch protection.