search

plume-sig / zk-nullifier-sig

Implementation of PLUME: nullifier friendly signature scheme on ECDSA
MIT License
133 stars 22 forks source link

22 #64

Closed skaunov closed 11 months ago

skaunov commented 11 months ago

tests weren't touched on purpose to raise additional awareness of those who will be modifying them to recheck implementations against each other

skaunov commented 11 months ago

I should notice another mildly confusing naming: s and sk. =(

Divide-By-0 commented 11 months ago

No one's using tests yet, feel free to edit those. S isn't ideal I agree, open to anything else.

Divide-By-0 commented 11 months ago

For circom, the code is way cleaner if you do this: https://github.com/plume-sig/zk-nullifier-sig/pull/48

Can you merge in that PR first, compile the circuits to make sure they work? It will make circom easier to read and maintain.

skaunov commented 11 months ago

Can you merge in that PR first, compile the circuits to make sure they work? It will make circom easier to read and maintain.

Ok, am running test suite rn. Merging amount is unexpected. :exploding_head:

skaunov commented 11 months ago

No one's using tests yet, feel free to edit those. S isn't ideal I agree, open to anything else.

I meant that I think it's actually good to preserve reasonable cognitive load in tests. I updated parts which were too confusing; though they're relatively rough and unpolished for good.

I'll think further about "S" though you can see absence of suggestions on my side. X)

skaunov commented 11 months ago

To be merged via #66 due to merging conflict.