Closed 0xmad closed 7 months ago
This looks great! Until @skaunov reviews it, do you want to send your wallet address and I can send a bounty?
@Divide-By-0 sorry, but I work at PSE :)
@Divide-By-0 sorry, but I work at PSE :)
Oh you know what, that makes a lot of sense LOL
@skaunov thanks for the review. I added pnpm just because it's faster and it's easier to use it as monorepo tool (I'll add workspaces later to get rid of relative paths inside circuits/circom
).
I just noticed that @Divide-By-0 asked actually to also merge this one. %)
Just noticed that we have path with repetition now: <circuits/circom/test/circuits>. I personally try to avoid this due to minor discomfort it brings, so want to attract your attention to this. Though if everybody fine with it, then...
@skaunov what's the problem with it? It's not going to be exported and it uses internally inside test folder.
Path at https://github.com/plume-sig/zk-nullifier-sig/blob/79c602670b8448c9a85d552ba8a8d8aa5bbede04/README.md?plain=1#L44 should also corrected, right? @0xmad
I also received when was quickly running the instructions.
devbox@pop-os:~/zk-nullifier-sig/circuits/circom$ pnpm run flatten-deps && pnpm run test
ERR_PNPM_NO_SCRIPT Missing script: flatten-deps
Command "flatten-deps" not found.
circuits/
path yes, should be corrected.
You don't need to run flatten-deps
with test. It's automatically run after pnpm install
.