plume-sig / zk-nullifier-sig

Implementation of PLUME: nullifier friendly signature scheme on ECDSA
MIT License
128 stars 22 forks source link

Add tests for wrapping `c` over $p$ #99

Open skaunov opened 4 months ago

skaunov commented 4 months ago

It might be a RustCrypto thing which just panics on certain methods when bytes yields the value larger than $p$, but it's still a worthy case to have in the suite across implementation to be sure that wrapping is done correctly, and that signatures equality can be facilitated.

skaunov commented 4 months ago

1) add $p$ to the test signature and verify 2) find a hash greater than $p$ 3) test the signing-verifying with it 4) consider adding Eq kind of trait in Rust implementations

(also hash improbable to be equal $p$ and basically should be rejected)