Closed Iximiel closed 7 months ago
Attention: 8 lines
in your changes are missing coverage. Please review.
Comparison is base (
91d56cb
) 84.10% compared to head (b81cac6
) 84.06%.:exclamation: Current head b81cac6 differs from pull request most recent head 7d301b4. Consider uploading reports for the commit 7d301b4 to get more accurate results
Files | Patch % | Lines |
---|---|---|
src/tools/DLLoader.cpp | 20.00% | 8 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
As we were discussing, I modified @GiovanniBussi's class to fit into plumed, with warnings.
I also reverted the changes from #985, since DLLoader::EnsureGlobalDLOpen makes using RTLD_GLOBAL more granular.
For example, on linux, an embedded python interpreter needs its .so to be loaded with RTLD_GLOBAL, for importing compiled modules, with this you can make only libPython*.so GLOBAL, and not the other part of the code that rely on it.
I am using DLLoader as a namespace for EnsureGlobalDLOpen.
Target release
I would like my code to appear in release 2.10
Type of contribution
Copyright
COPYRIGHT
file with the correct license information. Code should be released under an open source license. I also used the commandcd src && ./header.sh mymodulename
in order to make sure the headers of the module are correct.Tests