Closed gtribello closed 7 months ago
Hi @GiovanniBussi
Here is a PR with the benchmark tool that I wrote for plumed. Please feel free to modify it in whatever way you see fit.
Attention: 60 lines
in your changes are missing coverage. Please review.
Comparison is base (
0ae3da5
) 84.18% compared to head (433f809
) 84.11%. Report is 70 commits behind head on master.:exclamation: Current head 433f809 differs from pull request most recent head cc36bb8. Consider uploading reports for the commit cc36bb8 to get more accurate results
Files | Patch % | Lines |
---|---|---|
src/cltools/Benchmark.cpp | 25.53% | 35 Missing :warning: |
src/cltools/GenExample.cpp | 0.00% | 3 Missing :warning: |
src/core/Action.h | 70.00% | 3 Missing :warning: |
src/core/PlumedMain.cpp | 91.89% | 3 Missing :warning: |
src/cltools/Driver.cpp | 0.00% | 2 Missing :warning: |
src/core/TargetDist.cpp | 0.00% | 2 Missing :warning: |
src/core/WithCmd.h | 71.42% | 2 Missing :warning: |
src/core/Action.cpp | 75.00% | 1 Missing :warning: |
src/core/ActionShortcut.h | 0.00% | 1 Missing :warning: |
src/core/ActionToGetData.h | 0.00% | 1 Missing :warning: |
... and 7 more |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hello @GiovanniBussi
What is the status with this? It looks like you did a lot of commits on this PR. I think a lot of them are from a merge of master after you added the PyCV stuff?
Do you want me to look at anything here?
I am fixing a few stuff then I'll merge in master. I already merged master into this branch, and for some reasons, github doesn't understand that the only difference between this branch and master is the Benchmark.cpp file.
I added the possibility to load a previous version of the kernel, to do comparisons, and to run "forever" (until ctrl-C). I would like to also add the possibility to run with domain decomposition and MPI, because it's crucial for some other tests I am doing (see #1025)
I'll merge this in master today.
OK that is great. Thanks.
This tool runs plumed using a trajectory that is hard coded in the source code. It essentially works very much like driver, except the trajectory is fixed. You can use this to benchmark plumed calculations. The advantage of having the separate code is the the profiles you get from this tool are not influenced by lots of I/O.
Description
Added tool for benchmarking plumed
Target release
I would like my code to appear in release v2.10
Type of contribution
Copyright
COPYRIGHT
file with the correct license information. Code should be released under an open source license. I also used the commandcd src && ./header.sh mymodulename
in order to make sure the headers of the module are correct.Tests