search

plumed / plumed2

Development version of plumed 2
https://www.plumed.org
GNU Lesser General Public License v3.0
324 stars 269 forks source link

Possible bug in EDS and pesmd #1018

Closed GiovanniBussi closed 4 months ago

GiovanniBussi commented 4 months ago

While updating cppcheck I discovered two calls that might be bugs in pesmd and EDS, see this commit

@gtribello @whitead @hockyg

Specifically, the second argument of keys.addFlag should be a bool but is actually a literal string, silently converted to true. I temporarily silenced the warning but I think it should be fixes. If you suggest the proper fix I would apply it back in PLUMED 2.8 and 2.9 as well.

BTW, @gtribello I am still confused how one would be willing to set the default value for a flag to true. Shouldn't this argument be removed and always set to false?

GiovanniBussi commented 4 months ago

Closed here (fixed in v2.8 and later versions)