Closed Iximiel closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 85.90%. Comparing base (
221032c
) to head (9ccf5b9
).:exclamation: Current head 9ccf5b9 differs from pull request most recent head 8768f05. Consider uploading reports for the commit 8768f05 to get more accurate results
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Great! I see that other tests are not affected, I am afraid there was no test on the 2 N!= M case, or maybe no test was probing that point?
I would add something in the change log for version 2.8
Thanks!
I am afraid there was no test on the 2 N!= M case, or maybe no test was probing that point?
I think that was the reason it slipped trough the tests. We have to thank intel that approximates differently than gcc
I update the changelog, I think this can be squashed+merged
Description
First of all, sorry for the Friday afternoon PR.
As we discussed in #1038, here I patched the numerical instabilities around R0 in the non simplified rational switching function. And I used the test from #1038 for ensuring the correctness of the change (v2.8 won't pass the new test).
Before merging: should I update the changelog?
Target release
I would like my code to appear in release v2.8
Type of contribution
Copyright
COPYRIGHT
file with the correct license information. Code should be released under an open source license. I also used the commandcd src && ./header.sh mymodulename
in order to make sure the headers of the module are correct.Tests