plumed / plumed2

Development version of plumed 2
https://www.plumed.org
GNU Lesser General Public License v3.0
323 stars 269 forks source link

deactivate restart during parse only runs #1051

Closed gtribello closed 3 months ago

gtribello commented 3 months ago
Description

As discussed in the meeting today, if we make this change many eggs in the nest will pass as the problem with them is that people have upload a PLUMED input file that has RESTART in it but no hills file. If we thus suppress RESTART when we run parse-only mode the tests should pass.

Target release

I would like my code to appear in release 2.9

Type of contribution
Copyright
Tests
codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85.19%. Comparing base (1ae6aeb) to head (353ab7a).

:exclamation: Current head 353ab7a differs from pull request most recent head 8464e30. Consider uploading reports for the commit 8464e30 to get more accurate results

Files Patch % Lines
src/core/PlumedMain.cpp 60.00% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## v2.9 #1051 +/- ## ========================================== - Coverage 85.22% 85.19% -0.03% ========================================== Files 600 600 Lines 55578 55581 +3 ========================================== - Hits 47366 47355 -11 - Misses 8212 8226 +14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

carlocamilloni commented 3 months ago

It had a good impact, 12 eggs and around 50 inputs are now correct