Closed GiovanniBussi closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 83.33%. Comparing base (
103d111
) to head (2458078
).:exclamation: Current head 2458078 differs from pull request most recent head 028767e. Consider uploading reports for the commit 028767e to get more accurate results
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Avoid doing searches by atom number in the PDB for every distance calculation.
Only relevant for startup, not for the following calculation, but given the scaling of the EMST calculation with the number of atoms I think it's relevant. I didn't make precise timings, but my understanding is that:
N_wholemolecules * N_wholemolecules * log(N_PDB)
N_wholemolecules * N_wholemolecules
The additional
*log(N_PDB)
comes from the need to search the index of each atoms in the PDB in the inner loop.I tested on this input:
Startup time decreases from ~ 12 minutes to ~ 25 seconds.
@maxbonomi let me know if you have any concerns with merging this
Target release
I would like my code to appear in release v2.10