Closed gtribello closed 4 months ago
I hope this is correct. The tests that were not working now run.
Great, it means that the code was not too bad :-). I should probably replace the std::vector<void*>
with some custom class std::vector<DLimage>
or so.
I managed to get it working but I also put a warning in about putting a . in the names of actions. I think this is a recipe for trouble. Not sure if we should make that an error. What do you think?
I would actually forbid this. Or we might start phasing it out and give a warning now (and a failure in plumed 2.11)
Description
I have been doing some work on improving the PlumedToHTML code that generates the annotated input files for the tutorials and nest. The work is described in this PR. As part of this I have had to make some modifications to PLUMED. In particular, when you call PLUMED driver in parse only mode you can ask it to output two json dictionaries that contain:
Getting the definitions of the labels directly from plumed when you run driver is superior to getting this information from the syntax file as:
I tested the new version of PlumedTo HTML on all the inputs in the plumed nest and found a small number places where the new code does not work. This PR fixes those problems.
@GiovanniBussi can you please check whether I have done the code for the first commit correctly? The problem here is that I need to call registerKeywords for all the actions defined in the input file. This will not work if you do:
The problem with that is that the code for the actions in LOAD is not accessible that way. I thus came up with a way of doing by looking at what you did for creating actions. I hope this is correct. The tests that were not working now run.
Also note that I found one input in the nest like this:
I managed to get it working but I also put a warning in about putting a . in the names of actions. I think this is a recipe for trouble. Not sure if we should make that an error. What do you think?
Target release
I would like my code to appear in release 2.10
Type of contribution
Copyright
COPYRIGHT
file with the correct license information. Code should be released under an open source license. I also used the commandcd src && ./header.sh mymodulename
in order to make sure the headers of the module are correct.Tests