Iximiel
commented
1 month ago Before going down in particular (I think someone like @carlocamilloni or @GiovanniBussi should be better than me at commenting on the scientific side of the tests)
I took your comment and ran diff on all the couples of directories you listed.
Output in spoiler
Using `diffstat` to produce a readable report: - `diff rt-caliber rt-caliber-negres-zero | diffstat` ``` allforce.0.reference |62712 +++++++++++++++++++++++++-------------------------- plumed.dat | 1 2 files changed, 31357 insertions(+), 31356 deletions(-) ``` - `diff rt-jcouplings-mi rt-Metainference-averaging | diffstat` ``` plumed.dat | 1 + report.txt |only tmp |only 3 files changed, 1 insertion(+) ``` - `diff rt-emmi-gauss-mpi rt-coverage-EMMI-TEMP | diffstat` ``` COLVAR.reference | 2 deriva.reference | 412 +++++++++++++++++++++++++++---------------------------- plumed.dat | 2 3 files changed, 208 insertions(+), 208 deletions(-) ``` - `diff rt-emmi-gauss-mpi rt-coverage-EMMI-anneal-fact | diffstat` ``` plumed.dat | 2 ++ 1 file changed, 2 insertions(+) ``` - `diff rt-emmi-gauss-mpi rt-coverage-EMMI-ovstride | diffstat` ``` plumed.dat | 2 ++ 1 file changed, 2 insertions(+) ``` - `diff rt-jcouplings-mi rt-jcoupling-string-type | diffstat` ``` atom_forces.reference | 276 +++++++++++++++++++++++++------------------------- miorig.reference | 12 +- plumed.dat | 2 3 files changed, 145 insertions(+), 145 deletions(-) ``` - `diff rt-noe-mi rt-metainference-likelihood | diffstat` ``` COLVAR.reference | 24 ++++++++++++------------ plumed.dat | 1 + 2 files changed, 13 insertions(+), 12 deletions(-) ``` - `diff rt-jcouplings-mi rt-metainference-mc-chunksize | diffstat` ``` plumed.dat | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ``` - `diff rt-jcouplings-mi rt-metainference-optisigmamean-sem-max | diffstat` ``` plumed.dat | 1 + 1 file changed, 1 insertion(+) ``` - `diff rt-jcouplings-mi rt-metainference-optisigmamean-sem | diffstat` ``` plumed.dat | 1 + 1 file changed, 1 insertion(+) ``` - `diff rt-jcouplings-mi rt-metainference-regres-zero | diffstat` ``` MISTATUSmij.reference | 2 atom_forces.reference | 274 +++++++++++++++++++++++++------------------------- miorig.reference | 14 +- plumed.dat | 3 4 files changed, 147 insertions(+), 146 deletions(-) ``` - `diff rt-jcouplings-mi rt-metainferencebase-averaging | diffstat` ``` plumed.dat | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ``` - `diff rt-noe-mi rt-metainferencebase-likelihood | diffstat` ``` COLVAR.reference | 24 ++++++++++++------------ plumed.dat | 1 + 2 files changed, 13 insertions(+), 12 deletions(-) ``` - `diff rt-jcouplings-mi rt-metainferencebase-regres-zero | diffstat` ``` plumed.dat | 2 ++ 1 file changed, 2 insertions(+) ``` - `diff rt-jcouplings-mi rt-metainferencebase-sem-max | diffstat` ``` plumed.dat | 2 ++ 1 file changed, 2 insertions(+) ```in rt-Metainference-averaging you accidentally pushed tmp and the report.txt
For some tests there is no difference between the original one and the modified one:
- rt-emmi-gauss-mpi rt-coverage-EMMI-anneal-fact
- rt-emmi-gauss-mpi rt-coverage-EMMI-ovstride
- rt-jcouplings-mi rt-metainference-mc-chunksize
- rt-jcouplings-mi rt-metainference-optisigmamean-sem-max
- rt-jcouplings-mi rt-metainference-optisigmamean-sem
- rt-jcouplings-mi rt-metainferencebase-averaging
- rt-jcouplings-mi rt-metainferencebase-regres-zero
- rt-jcouplings-mi rt-metainferencebase-sem-max
- rt-jcouplings-mi rt-Metainference-averaging
This means that the test is passing through those lines (since the coverage is improving) but there is no proof of that happening in the output, we should either rethink the new tests or add some extra output references.
Mertcan-Puncist
Description
this pull request focuses on enhancing the coverage test result for the isdb/metainference
1- regtest/isdb/rt-caliber-negres-zero
i coppyed this original test
modified and name it
to cover:
covered isdb/Caliber.cpp lines|
2- regtest/isdb/rt-Metainference-averaging
i coppyed this original test
modified and name it
to cover:
covered isdb/Metainference.cpp lines|
3- regtest/isdb/rt-coverage-EMMI-TEMP
i coppyed this original test
modified and name it
to cover:
covered isdb/EMMI.cpp lines|
4- regtest/isdb/rt-coverage-EMMI-anneal-fact
i coppyed this original test
modified and name it
to cover:
covered isdb/EMMI.cpp lines|
5- regtest/isdb/rt-coverage-EMMI-ovstride
i coppyed this original test
modified and name it
to cover:
covered isdb/EMMI.cpp lines|
6- regtest/isdb/rt-jcoupling-string-type
i coppyed this original test
modified and name it
to cover:
covered isdb/Jcoupling.cpp lines|
7- regtest/isdb/rt-metainference-likelihood
i coppyed this original test
modified and name it
to cover:
covered isdb/Metainference.cpp lines|
8- regtest/isdb/rt-metainference-mc-chunksize
i coppyed this original test
modified and name it
to cover:
covered isdb/Metainference.cpp lines|
9- regtest/isdb/rt-metainference-optisigmamean-sem-max
i coppyed this original test
modified and name it
to cover:
covered isdb/Metainference.cpp lines|
10- regtest/isdb/rt-metainference-optisigmamean-sem
i coppyed this original test
modified and name it
to cover:
covered isdb/Metainference.cpp lines|
Note about test 9 and 10 :
These two tests covers the same lines between 1581-1639
11-regtest/isdb/rt-metainference-regres-zero
i coppyed this original test
modified and name it
to cover:
covered isdb/Metainference.cpp lines|
12- regtest/isdb/rt-metainferencebase-averaging
i coppyed this original test:
modified and name it:
to cover:
covered isdb/MetainferenceBase.cpp lines|
13- regtest/isdb/rt-metainferencebase-likelihood
i coppyed this original test:
modified and name it:
to cover:
covered isdb/MetainferenceBase.cpp lines|
14- regtest/isdb/rt-metainferencebase-regres-zero
i coppyed this original test:
modified and name it:
to cover:
covered isdb/MetainferenceBase.cpp lines|
15- regtest/isdb/rt-metainferencebase-sem-max
i coppyed this original test:
modified and name it:
to cover:
covered isdb/MetainferenceBase.cpp lines|
Target release
I would like my code to appear in release v2.9
Type of contribution
Copyright
COPYRIGHTfile with the correct license information. Code should be released under an open source license. I also used the commandcd src && ./header.sh mymodulenamein order to make sure the headers of the module are correct.Tests