plumed / plumed2

Development version of plumed 2
https://www.plumed.org
GNU Lesser General Public License v3.0
364 stars 289 forks source link

Removed py37 and py38 from macports CI #989

Closed Iximiel closed 11 months ago

Iximiel commented 11 months ago
Description

In #967, related to the EOL of python3.7, I lost the "py37" in the macports-CI, here I removed it

Type of contribution
Copyright
Tests
Iximiel commented 11 months ago

Tests were failing not due to the EOL of 3.7 the error message says:

Error: Processing of port py38-plumed failed ---> Some of the ports you installed have notes: OpenBLAS has the following notes: This version is built based on a base architecture for convenience, which may not be optimized for your system. To build a version customized for your machine, use the +native variant py38-pytest has the following notes: To make the Python 3.8 version of pytest the one that is run when you execute the commands without a version suffix, e.g. 'pytest', run:

sudo port select --set pytest pytest38

I cnverted this to a draft to check what is the problem

codecov-commenter commented 11 months ago

Codecov Report

Attention: 634 lines in your changes are missing coverage. Please review.

Comparison is base (943108b) 85.02% compared to head (afb930a) 84.12%. Report is 52 commits behind head on master.

:exclamation: Current head afb930a differs from pull request most recent head cc94d4f. Consider uploading reports for the commit cc94d4f to get more accurate results

Files Patch % Lines
src/isdb/EMMIVox.cpp 5.54% 596 Missing :warning:
src/isdb/SAXS.cpp 81.52% 34 Missing :warning:
src/core/PlumedMain.cpp 87.50% 2 Missing :warning:
src/pytorch/PytorchModel.cpp 95.65% 1 Missing :warning:
src/tools/DLLoader.cpp 80.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #989 +/- ## ========================================== - Coverage 85.02% 84.12% -0.91% ========================================== Files 601 602 +1 Lines 55309 56092 +783 ========================================== + Hits 47028 47185 +157 - Misses 8281 8907 +626 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Iximiel commented 11 months ago

I did some experimentation (see here) and I found that there may be linking problems with blas and numpy for python 3.8 and 3.7 in the macports installation, removing them the CI should pass

python 3.7 reached EOL this year and python 3.8 will reach EOL around October 2024

GiovanniBussi commented 11 months ago

@Iximiel should this be backported to maintained versions of PLUMED perhaps?

Iximiel commented 11 months ago

Philosophicallly not, but in practice yes, for the sake of the CI working Tomorrow I'm setting up a rebase for the 2.8 that shall then be merged into the 2.9, hopefully no conflict will arise