Closed Iximiel closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
ee93ec2
) 84.11% compared to head (1486479
) 84.10%. Report is 91 commits behind head on master.:exclamation: Current head 1486479 differs from pull request most recent head 2111ea0. Consider uploading reports for the commit 2111ea0 to get more accurate results
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I have modified the CI to also run the PyCV tests, but only for the linux test:
I do not know if adding another identical compilation to the linux wf is a good idea, but was the fastest set up possible.
I tried to be the less invasive possible, but as you can see Rocky linux has been changed a bit:
yum insalls a python that cannot be linked with pithon3-config --ldflags --embed
and so I modified the container recipe to install it.
Both for Fedora and Rocky I modified the the CI by adding a new Docker recipe that uses the previously compiled image to run pycv with the tests, this is more portable and the CI will be more clear if only PyCV fails
I see there are some conflict that are not possible to solve in the online editor, I will rebase this branch on master and then propose a non-draft PR.
Also, the merging https://github.com/plumed/plumed2/tree/autoconf-dladdr of makes the use of LOAD GLOBAL
obsolete
Description
The original work and ideas for PyCV are of @tonigi
This is the (draft) PR for PyCV.
PyCV gives the user the possibility to write a CV or a function in Python, with the possibility to use Python packages (like jax, sci-kit, etc..), while having access to some capability of plumed.
PyCV is a plug-in that can be LOADed in plumed.
Before setting this PR as ready to review some checks are needed:
Target release
I would like my code to appear in release 2.10
Type of contribution
Copyright
COPYRIGHT
file with the correct license information. Code should be released under an open source license. I also used the commandcd src && ./header.sh mymodulename
in order to make sure the headers of the module are correct.Tests