search

plunder-app / plndr-cloud-provider

A bare metal cloud provider for Kubernetes
Apache License 2.0
40 stars 5 forks source link

add 1.6 example with labels and pass unique leader elect name #21

Closed poidag-zz closed 4 years ago

poidag-zz commented 4 years ago

relates to #18. Not sure if we want to default in flag configuration.

thebsdbox commented 4 years ago

Without specifying an actual resource name, i'm not sure what the name will default too.. perhaps something like - --leader-elect-resource-name=plndr-cloud-controller ?

poidag-zz commented 4 years ago

plndr-cloud-controller sounds good. I think maintaining an example install that shows passing through of flags to the cloud controller manager lib would be a lot less friction for now without defining a customer leaderElectionConfig WDYT? @thebsdbox

poidag-zz commented 4 years ago

Also, Is there a plan to transition this from a Pod to a Deployment. Delete operations for pods are often performed as a part of remediation and debugging and delete on a single pod could leave the controller inadvertently removed from the cluster. Let me know and I'll create a separate issue for this.

thebsdbox commented 4 years ago

Yes, we should move to a deployment!