add crypto key validation

pluralsh / plural-cli

cli for the plural platform

MIT License

27 stars 10 forks source link

add crypto key validation #342

Closed zreigz closed 1 year ago

zreigz commented 1 year ago

Summary

Create a .keyid file w/ the sha256 digest of the encryption key.
Fix the problem with the workspace.yaml created outside the git repository
- Add new command to generate key fingerprint file: plural crypto key-fingerprint

Labels

Test Plan

Checklist

[ ] If required, I have updated the Plural documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] I have added a meaningful title and summary to convey the impact of this PR to a user.
[ ] I have added relevant labels to this PR to help with categorization for release notes.

zreigz commented 1 year ago

@michaeljguarino PTAL

michaeljguarino commented 1 year ago

Another thing I realized, and I think you probably covered but we should double-check, you should make sure the sha format here matches what's done in plural crypto backups list (you can verify by just creating a backup first w/ plural crypto backups create)

zreigz commented 1 year ago

Unfortunately, the SHA format is different than for plural crypto backups but I am not sure if it's relevant. We compare them in the flight using the same SHA function

michaeljguarino commented 1 year ago

@zreigz so the difference between the server and here is that we base32 encode it instead of base64 encode it. If you swap the schemes I think that will keep them aligned

zreigz commented 1 year ago

@michaeljguarino I have changed to base32 and they match, thanks