search

pluralsight / mob-timer

A mob programming application
Apache License 2.0
65 stars 26 forks source link

Interrupt full screen apps #11

Open TravisBumgarner opened 6 years ago

TravisBumgarner commented 6 years ago

When mobbing with Visual Code set to full screen the mob timer won't interrupt the app when time's up. It'd be nice if this was possible.

allan-stewart commented 6 years ago

I'm guessing that you are talking about Mac OS's full screen ability? If so, I poked around a bit and found this electron issue that discusses what I think we'd need: https://github.com/electron/electron/issues/10078

Based on my read of that thread, we might be able to do the full screen interrupt if we play around with some of the existing options. But we might need a feature that does not yet exist, and it looks like there has been no activity on that PR in a while...

I'm not sure when I'd get the time to mess with this, but hopefully somebody will take a crack at it. (I also don't use full screen very often on Mac, so I'm not sure I'm the right audience.) Also related: I wonder how the timer does with spaces (multiple virtual windows)?

TravisBumgarner commented 6 years ago

Womp womp. I'd be down to perhaps explore this in the future. Don't know anything about Electron though. Maybe now's a good time to start.

dignite commented 6 years ago

@TravisBumgarner please try out #17 and feedback, my initial tests worked well but always good to get some new perspectives and tests on more devices

allan-stewart commented 5 years ago

I've merged #17 -- if that works sufficiently, we can close this issue. Unfortunately we do have to fight against Electron / MacOS limitations (and how they differ from the core concept of the timer) as discussed in the PR. But I'm hopeful that it's usable for full-screen users as-is now.