search

pluralsight / mob-timer

A mob programming application
Apache License 2.0
65 stars 26 forks source link

Test and build with Travis CI #20

Closed dignite closed 5 years ago

dignite commented 5 years ago

What

Run tests and build the app on the following platforms in Travis CI:

image

Bonus

Avoid setTimeout in tests, instead using sinon.useFakeTimers(). This change was due to failing tests in Travis CI on OSX.

Future improvements

Attach built apps to github release when tagging

dignite commented 5 years ago

@allan-stewart I would love some feedback on this one when you have time 🙂

allan-stewart commented 5 years ago

Though I've seen Travis CI used by a lot of projects, I haven't actually used it myself. But it's pretty unobtrusive and this looks like a good addition (including the change to make the timer tests more reliable).

The timer seems to go in waves of contributions -- nothing happens for a long time and then suddenly there is a spike of interest. So most of the time, CI has been easy to accomplish manually (by which I mean the core concept of continuous integration where we integrate changes into master frequently) and so I didn't see the need to incur the overhead of introducing a CI tool.

I'm not quite ready to set up an "official" CI build for the project just yet, but I don't see any reason to not merge this in and people can set up builds for their forks as they see fit.

dignite commented 5 years ago

Cool, thanks for the feedback @allan-stewart ! If you want to enable Travis for the pluralsight/mob-timer repo it is literally just logging in and pressing a button. I suggest you try it out! It can always be disabled at a later point. It is free for open source.