search

pluralsight / spavro

Spavro is a (sp)eedier avro library -- Spavro is a fork of the official Apache AVRO python 2 implementation with the goal of greatly improving data read deserialization and write serialization performance.
Apache License 2.0
26 stars 15 forks source link

Re-generate fast_binary.c #15

Closed JohnEmhoff closed 3 years ago

JohnEmhoff commented 3 years ago

Python 3.9 removed the function tp_print, causing the cython extension to fail to compile. This simply re-generates the extension on python 3.9 with a newer version of cython.

I have no idea if there are other ramifications here or if anything needs to be tested on older versions -- let me know if so.

Fixes https://github.com/pluralsight/spavro/issues/13

mikepk commented 3 years ago

Thanks @JohnEmhoff -- updating this has been on my todo list for a while. This has also run afoul of travis-ci.org no longer working and requiring migration to travis-ci.com so that the test suite will run against all targeted python versions. Once I get the travis-ci integration working again we can test the PR.

mikepk commented 3 years ago

Hi @JohnEmhoff so I haven't been at pluralsight for a while now (two years now) and I don't own the pluralsight/spavro github repo anymore. I've gone ahead and done basically the same thing you did over on my fork https://github.com/mikepk/spavro and added the new travis.ci config over there. It's passing all the tests on all versions (2.7 and 3.4-3.9) with the newer Cython / c extension. I own the Pypi package so I've gone ahead and published the new version 1.1.24 to pypi. (I can't even merge and/or close this pull request :) )

JohnEmhoff commented 3 years ago

Thanks very much! Especially since it sounds you're maintaining it out of the goodness of your heart <3 <3