Closed cbbfcd closed 4 years ago
Merging #54 into master will increase coverage by
1.5%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #54 +/- ##
======================================
+ Coverage 62.5% 64% +1.5%
======================================
Files 1 1
Lines 24 25 +1
Branches 7 7
======================================
+ Hits 15 16 +1
Misses 5 5
Partials 4 4
Impacted Files | Coverage Δ | |
---|---|---|
src/react-anime.js | 64% <100%> (+1.5%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d4c23d7...d37a24b. Read the comment docs.
Curious about your new keys, did you mean to make it animei for each key? Or did I misread the template string?
It’s my stupid mistake, so code-review is very important, i fixed it. 😄
Sorry for the late reply!
Good idea, I went ahead and added this in 9487f04f316abd1ef4b8cf3ad99a8ee4fb99202c, thanks for pointing this out!
in-depth explanation on the negative impacts of using an index as a key