Closed ferricoxide closed 6 years ago
If the NoReboot parameter is fed a value of false, deployment will fail because the reboot command referenced by cfn-init is not actually defined
NoReboot
false
reboot
cfn-init
User should be able to feed either boolean-value to the NoReboot parameter.
As written, only the true value is supported when feeding booleans to the NoReboot parameter.
true
Launch template with NoReboot set to false
Add a:
"reboot": { "commands": { "10-reboot": { "command": "shutdown -r +1 &" } } },
Block to the "AWS::CloudFormation::Init": {} section of the Templates/make_jenkins_EC2-instance.tmplt.json and Templates/make_jenkins_Agent-instance.tmplt.json files.
"AWS::CloudFormation::Init": {}
Templates/make_jenkins_EC2-instance.tmplt.json
Templates/make_jenkins_Agent-instance.tmplt.json
@murphyj21 dunno where you want this on the priority list — first it's been triggered since the templates were authored (May 2017!).
Closed by #19
Problem Description:
If the
NoReboot
parameter is fed a value offalse
, deployment will fail because thereboot
command referenced bycfn-init
is not actually definedExpected Behavior:
User should be able to feed either boolean-value to the
NoReboot
parameter.Actual Behavior:
As written, only the
true
value is supported when feeding booleans to theNoReboot
parameter.(Detailed) Steps to reproduce:
Launch template with
NoReboot
set tofalse
(Optional) Fix recommendation:
Add a:
Block to the
"AWS::CloudFormation::Init": {}
section of theTemplates/make_jenkins_EC2-instance.tmplt.json
andTemplates/make_jenkins_Agent-instance.tmplt.json
files.