plus3it / cfn-jenkins

Deploy Jenkins master and agents onto STIG-hardened EL7 Amazon instances
Apache License 2.0
2 stars 7 forks source link

Standalone EC2 Templates Fail to Define the "reboot" Comman for `cfn-init` #13

Closed ferricoxide closed 6 years ago

ferricoxide commented 6 years ago

Problem Description:

If the NoReboot parameter is fed a value of false, deployment will fail because the reboot command referenced by cfn-init is not actually defined

Expected Behavior:

User should be able to feed either boolean-value to the NoReboot parameter.

Actual Behavior:

As written, only the true value is supported when feeding booleans to the NoReboot parameter.

(Detailed) Steps to reproduce:

Launch template with NoReboot set to false

(Optional) Fix recommendation:

Add a:

"reboot": {
  "commands": {
    "10-reboot": {
      "command": "shutdown -r +1 &"
    }
  }
},

Block to the "AWS::CloudFormation::Init": {} section of the Templates/make_jenkins_EC2-instance.tmplt.json and Templates/make_jenkins_Agent-instance.tmplt.json files.

ferricoxide commented 6 years ago

@murphyj21 dunno where you want this on the priority list — first it's been triggered since the templates were authored (May 2017!).

ferricoxide commented 6 years ago

Closed by #19