[Bug] `amigen8-build.sh` Script Attempts to Install AWS CLI Utilities On Non-AWS VM-Templates

[ferricoxide]

Expected behavior

Only Amazon Machine Images should have AWS utils installed

Actual behavior

All build-targets attempt to install the AWS utils

Steps to reproduce behavior

1. Execute spel within an alternate build environment (discovered in Azure);
2. Monitor Logs
3. Note the attempted execution of the AWS CLI steps

Context/Specifications

Things like:

• Template name
• AWS Component
• OS/AMI information

Suggestions for fix

Update the spel/scripts/amigen8-build.sh script's BuildChroot function to make execution of the

 # Invoke AWSutils installer
 bash -euxo pipefail "${ELBUILD}"/$( ComposeAWSutilsString ) || \
   err_exit "Failure encountered with AWSutils.sh"

Block conditional on the CLOUDPROVIDER being aws.

Relevant references

• links to "best practices" or other guide(s)
• ...
• ...

[ferricoxide]

Have opened Issue #82 in the AMIgen8 project for the creation of an AzureUtils.sh script to act as an Azure-specific analogue to the current, AWS-specific AWSutils.sh script. Once this script is merged, the fix for this project's amigen8-build.sh script will be to add branch-logic to invoke the appropriate CSP-script based on the value of the CLOUDPROVIDER variable.