search

plus3it / spel

STIG-Partitioned Enterprise Linux (spel)
Other
91 stars 61 forks source link

Try to push HTTP_PROXY setting to AzureUtils invocation #611

Closed ferricoxide closed 1 year ago

ferricoxide commented 1 year ago

Closes the loop on AMIgen8 Issue #86

ferricoxide commented 1 year ago

go codebuild go

ferricoxide commented 1 year ago

go codebuild go

ferricoxide commented 1 year ago

I'm assuming that, because HTTP_PROXY is simply being declared and not exported, needed to add an explicit export to the AzureUtils.sh script to make it available to that script

lorengordon commented 1 year ago

I'm assuming that, because HTTP_PROXY is simply being declared and not exported, needed to add an explicit export to the AzureUtils.sh script to make it available to that script

Could probably just add the var to the export in the spel build script also... https://github.com/plus3it/spel/blob/980f7a42648a6adf7060b47b09d16a9542083b58/spel/scripts/amigen8-build.sh#L132

ferricoxide commented 1 year ago

Potentially/probably a "six of one…" case, but, the method I chose was in an attempt to limit potential side-effects by only exporting it to the AzureUtils.sh script.

lorengordon commented 1 year ago

Potentially/probably a "six of one…" case, but, the method I chose was in an attempt to limit potential side-effects by only exporting it to the AzureUtils.sh script.

Blergh, I got turned around. Saw the issue reported on Amigen8, and assumed the PR was there also. I think the implementation is better off in spel, not super concerned with the difference between your actual approach and my prior suggestion.