plushu / plushu-deploy-app-local-container

Runs the "web" process of a built App Container locally.
MIT License
0 stars 0 forks source link

Stop and cleanup in a backgrounded, disowned process when failing over #11

Open stuartpb opened 9 years ago

stuartpb commented 9 years ago

In writing https://github.com/heroku/heroku-buildpack-nodejs/issues/217#issuecomment-95363232, I realized a slow-to-halt app doesn't have to slow down the user-facing part of deployment.

if plushu-deploy-local-container were to background and disown app stopping the way Heroku does; however, that trades off good performance in a failure case (if your 12-factor app isn't just dropping everything on SIGTERM, you've probably designed it wrong) for the potential for problems to happen when nobody is looking, which is probably why I'm not going to do this any time soon.