search

plushu / plushu-deploy-app-local-container

Runs the "web" process of a built App Container locally.
MIT License
0 stars 0 forks source link

Separate hook for local deployment #9

Closed stuartpb closed 9 years ago

stuartpb commented 9 years ago

I feel like this plugin's behavior should be placed under another layer of hook (called by a "deploy-app" hook in this plugin) specific to local deploys. Lots of local stuff right now is written with the assumption that deploy is local, and while that's okay (as right now those addons only make sense in a local-deploying ecosystem), it'll likely cause problems in the future. Namely, adding / removing / manipulating addons requires the app to be restarted.

Also, maybe it's worth exposing a bit more granularity for these cases where the local app needs to be stopped, then (re)started (so the app can be stopped, an addon can be upgraded, then the app is started again).

stuartpb commented 9 years ago

Maybe this could then also have a transitioning "restart" hook that could be targeted for failover, and be filled by a brute stop-start for the non-failover implementation (possibly these would be two separate plugins)?

stuartpb commented 9 years ago

Looks like this is all going to be one plugin, using these hooks, to implement #4.