plusjade / jekyll-bootstrap

The quickest way to start and publish your Jekyll powered blog. 100% compatible with GitHub pages.
jekyllbootstrap.com
MIT License
3.35k stars 1.71k forks source link

Consistency Pass? #251

Open groundh0g opened 9 years ago

groundh0g commented 9 years ago

Any objections to making a pass through the _includes/JB/* scripts to make them self-consistent, based on issue #42?

logic would replace missing include parameter values with previously-expected state variables so that existing implementations aren't affected

  • include detailed usage notes, with examples
  • formatted for readability
  • wrap logic in {% capture jbcache %}...{% endcapture %}{% assign jbcache=nil %} to avoid polluting HTML with tons of whitespace.
groundh0g commented 9 years ago

After giving it a little more thought, I believe this task should be pushed to the next release (v 0.5.0).

That's when I'll be cleaning up the development branch. If I do the cleanup pass before, it'll likely make merging development changes much harder.

groundh0g commented 9 years ago

This needs to happen later rather than sooner. Refactoring early will introduce more merge conflicts. Bumping to next release to keep this release clean.