Closed adamoyoung closed 3 weeks ago
Yes, I think this is a good idea
I've implemented this in my own branch, when we merge I will try to fix it elsewhere
Thank you!
I have also added this to the main branch now: https://github.com/pluskal-lab/MassSpecGym/blob/d67eeb35bb3b068d8c47109a5bc416bbffcf42c7/massspecgym/models/base.py#L37C9-L37C36
lmao I reworked my branch to not use it anymore 🙃 will change it back
https://github.com/pluskal-lab/MassSpecGym/blob/2d16eb959a023a15cd0e485888415465789df20e/massspecgym/models/base.py#L12-L14
Can we just use
self.save_hyperparameters()
then reference these variables withself.hparams
? This is standard practice in PL.I would propose changing it to: