Closed thaddeusgeek closed 3 years ago
ok no hurry cuz there are some other bugs can u add me on qq 628552
Hi seoaqua,
Thank you very much for the patches! I have not been actively updating / maintaining this software recently. But if you fixed the bugs you mentioned and I'm very happy to merge the patches. Thanks again!
Best, pluskid
On Sun, Jun 22, 2014 at 6:45 PM, seoaqua notifications@github.com wrote:
ok no hurry cuz there are some other bugs can u add me on qq 628552
— Reply to this email directly or view it on GitHub https://github.com/pluskid/rmmseg-cpp/pull/4#issuecomment-46776638.
ok I'm learning how to auto compile your code. maybe it's a whole new structure of folders, cuz i dont know which tool you were using, definitely not hoe. in that case i have to start a new project which says it originates from yours. is that ok?
咱都是中国人就别说英文了 你加我qq不行吗 我又不骚扰你=.=
好的……不好意思,因为 QQ 平时不用的……
项目你随便 fork 没有问题的,我忘记当时用的什么 tool 了,类似于 hoe 的但是是 self-hosted 的,就是生成项目之后不需要依赖于原工具的。
On Wed, Jun 25, 2014 at 6:24 PM, seoaqua notifications@github.com wrote:
咱都是中国人就别说英文了 你加我qq不行吗 我又不骚扰你=.=
— Reply to this email directly or view it on GitHub https://github.com/pluskid/rmmseg-cpp/pull/4#issuecomment-47078879.
@pluskid 前辈好,昨天我也试图解决rmmseg-cpp的windows build问题,我在这个PR的基础上工作了6小时后发现,目前的ruby的native编译机制改进好大。。。也就是说,无论我在rmmseg-cpp的代码上怎么改,都改不好(但诡异的是,2011年发布的0.2.9却可以在最新版本的ruby上欢快的编译。。),一怒之下,我按照最新文档重新建立了文件结构,一下子简单好多,目前rmmseg-cpp-new也可以在windows下跑了。
但是我觉得这样似乎不太好,毕竟未在原作者的基础上工作,所以,我想问一下您现在这个rmmseg-cpp还维护么?如果还在维护,我愿意继续多花点时间将这部分工作port回rmmseg-cpp,但代码结构估计是要大删大改(编译机制support这部分,核心代码我肯定是没能力改。。)。
盼回复。
@Eric-Guo 鉴于我现在已经没有在维护这个项目了,所以你随便改没有关系。不能 port 回原来的代码树也没有问题。 :)
谢谢,那我还是省点力,直接用rmmseg-cpp-new算了,无论如何,感谢您的贡献,目前国内很多公司都用ruby-pinyin来提供汉字转拼音的功能。
@Eric-Guo OK,我在 readme 里加了一个链接到你的 repo。
请问windows下安装GEM包是否必须安装VC或VS,安装报错“nmake不是内部或外部命令”
@thaddeusgeek 准备挖矿?
有一个奇怪的 commit,那我直接关掉这个 pr 吧。
Hi @seoaqua , Thank you very much for the pull request! Can you please reduce
max_word_length
to 10 or 8? I'm not quite sure we really need 20. This affect the performance IIRC and this parameter is related tomax_tmp_words
in some intricate ways. Once you made the changes (or if you convince me that there is no need to change) I'm very happy to merge your PR. Thanks again!