search

plusls / oh-my-minecraft-client

oh-my-minecraft-client
GNU Lesser General Public License v3.0
138 stars 62 forks source link

[1.19.1] OMMC fails to find Magiclib (0.5.33, 1.19.1) #50

Open Notoriousi opened 2 years ago

Notoriousi commented 2 years ago

OMMC throws up the following error whilst having Magiclib 0.5.33 installed: A potential solution has been determined: Install magiclib-1_19, version 0.5.30 or later. Unmet dependency listing:

Mod 'Oh My Minecraft Client for 1.19' (ommc-1_19) 0.5 requires version 0.5.30 or later of magiclib-1_19, which is
missing!

After I removed the requirement for it, it still fails to find it: ModResolutionException: Mod discovery failed!

at net.fabricmc.loader.impl.discovery.ModDiscoverer.lambda$discoverMods$1(ModDiscoverer.java:146)
at net.fabricmc.loader.impl.util.ExceptionUtil.gatherExceptions(ExceptionUtil.java:33)
at net.fabricmc.loader.impl.discovery.ModDiscoverer.discoverMods(ModDiscoverer.java:146)
at net.fabricmc.loader.impl.FabricLoaderImpl.setup(FabricLoaderImpl.java:210)
at net.fabricmc.loader.impl.FabricLoaderImpl.load(FabricLoaderImpl.java:187)
at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:148)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:68)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
at java.base/java.lang.reflect.Method.invoke(Method.java:577)
at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:210)
at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:245)
at org.multimc.EntryPoint.listen(EntryPoint.java:143)
at org.multimc.EntryPoint.main(EntryPoint.java:34) ParseMetadataException: Error reading fabric.mod.json file for mod at
C:\Games\MultiMC\instances\Main\.minecraft\mods\oh-my-minecraft-client-1.19-0.5.jar:
net.fabricmc.loader.impl.lib.gson.MalformedJsonException: Expected name at line 36 column 4 path $.depends.minecraft at net.fabricmc.loader.impl.metadata.ModMetadataParser.parseMetadata(ModMetadataParser.java:57)
at net.fabricmc.loader.impl.discovery.ModDiscoverer$ModScanTask.parseMetadata(ModDiscoverer.java:465)
at net.fabricmc.loader.impl.discovery.ModDiscoverer$ModScanTask.computeJarFile(ModDiscoverer.java:287)
at net.fabricmc.loader.impl.discovery.ModDiscoverer$ModScanTask.compute(ModDiscoverer.java:250)
at net.fabricmc.loader.impl.discovery.ModDiscoverer$ModScanTask.compute(ModDiscoverer.java:212)
at java.base/java.util.concurrent.RecursiveTask.exec(RecursiveTask.java:100)
at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182)
at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655)
at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622)
at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)

MalformedJsonException: Expected name at line 36 column 4 path $.depends.minecraft

at net.fabricmc.loader.impl.lib.gson.JsonReader.syntaxError(JsonReader.java:1570)
at net.fabricmc.loader.impl.lib.gson.JsonReader.doPeek(JsonReader.java:505)
at net.fabricmc.loader.impl.lib.gson.JsonReader.hasNext(JsonReader.java:414)
at net.fabricmc.loader.impl.metadata.V1ModMetadataParser.readDependenciesContainer(V1ModMetadataParser.java:443)
at net.fabricmc.loader.impl.metadata.V1ModMetadataParser.parse(V1ModMetadataParser.java:151)
at net.fabricmc.loader.impl.metadata.ModMetadataParser.readModMetadata(ModMetadataParser.java:142)
at net.fabricmc.loader.impl.metadata.ModMetadataParser.readModMetadata(ModMetadataParser.java:105)
at net.fabricmc.loader.impl.metadata.ModMetadataParser.parseMetadata(ModMetadataParser.java:45)
... 10 more
Notoriousi commented 2 years ago

Update: Magiclib 0.5.34 did not fix this

bAdOoWindy commented 2 years ago

fails to find Magiclib (0.5.37, 1.19.2)

Hendrix-Shen commented 2 years ago

See https://github.com/Hendrix-Shen/MagicLib/issues/7.