plusone-robotics / realsense

Intel(R) RealSense(TM) ROS Wrapper for D400 series and SR300 Camera
http://wiki.ros.org/RealSense
Apache License 2.0
0 stars 5 forks source link

Node should stay alive even if realsense disconnects #20

Closed jonlwowski012 closed 5 years ago

jonlwowski012 commented 5 years ago

Node should stay alive even if realsense disconnects. The node will continually look for a new realsense if the current realsense disconnects.

The pull request depends on https://github.com/plusone-robotics/realsense/pull/16/

The original MR for this is here https://github.com/plusone-robotics/realsense/pull/17

Review items

jonlwowski012 commented 5 years ago

@130s Can this be merged yet?

130s commented 5 years ago
  • [x] Verify w/hardware

Just confirming; is this still valid (i.e. is the updated change tested)?

jonlwowski012 commented 5 years ago
  • [x] Verify w/hardware

Just confirming; is this still valid (i.e. is the updated change tested)?

Yes I re-tested this by running the realsense and then unplugging and replugging it back it and confirming that the camera automatically reconnected without the driver dying

130s commented 5 years ago

Closed in favor of https://github.com/plusone-robotics/realsense/pull/21