search

plusone-robotics / realsense

Intel(R) RealSense(TM) ROS Wrapper for D400 series and SR300 Camera
http://wiki.ros.org/RealSense
Apache License 2.0
0 stars 5 forks source link

[Cherry-pick] Support cleanly resetting driver and hot-plugging sensors. #31

Closed 130s closed 4 years ago

130s commented 4 years ago

This is a cherry-pick of the changes that was merged in at https://github.com/plusone-robotics/realsense/pull/28 into an older development branch on this fork.

Branch

Review items includes:

  1. Dev-test. This will likely be done on a in-house, integrated application.
  2. Code review
    • [ ] Whether newer changes in the upstream repo's development is not removed unintentionally.

TODOs post-merge

  1. [ ] Tag on plusone-robotics' fork.
  2. [ ] PR to the Intel's upstream.
130s commented 4 years ago

@malban Would you have time to review today 11/4W if you can spot outstanding logic change?

130s commented 4 years ago

I confirmed the claimed functionality still works with the standalone Realsense driver with rs_camera.launch respawn:=true option.

Because while making this PR merge conflict inevitably happened, I'll wait for our POR's internal QA process (that integrates Realsense driver into our internal application) for vetting before merging.