search

plusonelabs / calendar-widget

An calender widget for your Android home screen.
Apache License 2.0
369 stars 127 forks source link

Adjust event color opacity/disable #234

Closed xuvatilavv closed 4 years ago

xuvatilavv commented 8 years ago

Solves issue #174.

Adds Appearance preference option to change event color opacity to 100%, 50%, 0%, or Disable. Percentages affect alpha value and leaves space reserved, "Disable" sets the bar to "GONE" leaving a more condensed layout for narrow widget sizes.

Only includes English locale strings.

mpost commented 8 years ago

Thanks for the contribution. I will have a closer look.

mpost commented 8 years ago

A few comments... Wouldn't a slider with some more discrete values be nicer? Eg. with 10% increments. Also Could you squash your commits into one?

xuvatilavv commented 8 years ago

Squashed the commits.

A slider would definitely be nicer and is what I originally intended, but I wasn't sure how to do it. I researched a bit and tried pulling the slider from the color picker already in the app but couldn't get it to work on its own. I've been working on some personal projects for a while so I haven't gone back to look at it yet.

yvolk commented 4 years ago

@xuvatilavv Closing as the PR is outdated now. BTW recently we migrated to the new Color Picker that allows to change opacity as you wish in a more intuitive way. Note: Please create new PRs in that repository: https://github.com/andstatus/todoagenda/pulls