search

plusonelabs / calendar-widget

An calender widget for your Android home screen.
Apache License 2.0
369 stars 126 forks source link

Event and background colors and shading problem #325

Closed bushrang3r closed 4 years ago

bushrang3r commented 4 years ago

There is only one setting for event text shading but different color options for event background, past event background and future background. This limits choices for background coloursimage_2019-09-15_07-48

Perhaps some sub-menus in settings and more colour options would solve this.

e.g.

Settings | Colors | Past

Day header text shading Event text shading Event background color

Settings | Colors | Today

as above

Settings | Colors | Future

as above

I agree there are already a lot of settings so perhaps there is an easier way to implement this.... Maybe day header text shading and event text shading could be just one option. ie. they are the same shading. This would create only 2 color options in the settings structure above, rather than 3.

yvolk commented 4 years ago

@bushrang3r Thank you for suggestions.

  1. Regarding settings structuring and ordering. As you may have noticed, I changed an order of settings in each section (mostly) to correspond to the order of elements on the screen: starting from Widget header and down... Similarly we do have "Past events" and "Current and future events" sections inside "Event filters". So I think that structuring Colors settings into "Past events", "Today's events" and "Future events" will be logical and will really help to find needed settings.

  2. Regarding day header shading vs event shading. I separated them only recently in #218. Previously Day header color was dependent on event color, but as some users noticed, it was always light and never black... Now we can set all widget text black or white thus adjusting for different backgrounds.

  3. And finally: Why do we have "Text shading" with only 4 values and not continuous "Text color" with the same color picker as for backgrounds? Actually "shading" means changing a "style", i.e. a group of attributes, together, including switching between white and black icons. See the four "Shadings" here: https://github.com/andstatus/todoagenda/blob/master/app/src/main/res/values/themes.xml

bushrang3r commented 4 years ago

OK, thanks. I understand.

  1. The problem with this (as you can see in my screenshot) is that if my header text shading or event text shading is dark or black, I can't have any dark backgrounds for past, today, or future. They must all be light colours.
yvolk commented 4 years ago

@bushrang3r Yes, I see. So we need 2 * 3 text shading settings instead of 2. I will do this.

yvolk commented 4 years ago

Done in v.3.0.5 Please check in #320

In order to minimize number of settings the app hides color settings that are not actual. It hides color settings for Day headers if "Show Day headers" setting is turned off. "Past events" section is removed completely if no past events may be shown and no task sources selected.

yvolk commented 4 years ago

@bushrang3r I like this extention so much that I even started to consider changing default today's colors. Previously all events where white text on dark background. Now we can empathize today by inverting the colors. I found that such a change really makes today easily visible. What do you think? Screenshot_2019-09-20-08-19-03-570

bushrang3r commented 4 years ago

@yvolk Yes! It's wonderful! I love it. It's great to be able to show past, today, and future with different colours. Very easy and quick to differentiate events and days. It's very customizable now. I'll keep testing this beta and keep using it everyday. Thanks for all your hard work!