search

plusonelabs / calendar-widget

An calender widget for your Android home screen.
Apache License 2.0
369 stars 126 forks source link

Request: add option for horizontal line placement #326

Closed haakonhh closed 4 years ago

haakonhh commented 4 years ago

Hello Yuri, Thank you for a wonderful widget! This widget is the single most important part of my Android phone!

But, since the 3.0 beta the horizontal lines in the day header was moved to a less ideal location. I can see that this was discussed in issue #154 (https://github.com/plusonelabs/calendar-widget/issues/154), but I think this looks worse now. The design element was elegant, but now it looks a bit clumsy, especially the first entry.

Maybe it is possible to add an option switch to this, so that we may choose to have the separator above or below the day header?

Thank you again for all your work!

yvolk commented 4 years ago

Hello Haakon, thank you for your kind words! As you may have noticed, the discussion about Day header separator placement was drived by pragmatic goal: avoid User's confusion. I was wandering, why the separator was placed under Day header in the first place. And I think that found the source: I opened Settings of my Samsung Galaxy III (which is about 5 years old) and saw practically the same design. Since that time Android style changed greatly, and now that old theme looks outdated...

haakonhh commented 4 years ago

I think the line was more of an aesthetically line, and not a separator. More like the previous title style in Microsoft Word: wd10_select_style

I think it looked better before (sorry for the poor-quality image): IMG_0010

Now it looks kind of broken, especially with the misplaced line on the very top: 2097974980

But, if the line will continue to be placed above the date, I will propose the following tweaks:

Thank you! :)

yvolk commented 4 years ago

I think the line was more of an aesthetically line, and not a separator. More like the previous title style in Microsoft Word.

Yes, I agree. This is how we see it now :-)

I will easily hide the line in the first Day header, thank you for noticing. I'm not sure how many actual pixels to add as its replacement. Any concrete suggestion e.g. using screenshot?!

BTW Did you notice that in recent Beta I added one-line empty element to the bottom of the list in order easily see that the list ends here... ?!

yvolk commented 4 years ago

@haakonhh I fixed current layout as you suggested AND added the new option "Horizontal line below Day header" as you originally asked for. Please try v.3.0.8 here: #320

Tested this works even on Android v.4.3 device-2019-09-28-094843-galaxy-s3

haakonhh commented 4 years ago

Sorry for mye late reply!

I have tested 3.0.8 now.

Thank you again! :)