plusonelabs / calendar-widget

An calender widget for your Android home screen.
Apache License 2.0
369 stars 126 forks source link

Today's event color overwrites previous event color #327

Closed Clubby2010 closed 4 years ago

Clubby2010 commented 4 years ago

I would like to see all previous events in yellow (even previous events from today). I set show previous events which ended yesterday. The yellow color is shown for all events which ended yesterday but not for events which ended today. In the previous version it was shown correctly. I assume the new option for today's background color overwrites the previous events background color. For myself,I would like to disable today's background color.

yvolk commented 4 years ago

@Clubby2010 Yes, really. I remember I looked at the new "Today's color" feature and thought that something changed. But I didn't spot the difference :-)

  1. See comparison of v.3 (on the left) vs v.1. Today's event is in the future:

todays-colors-001-3-0-8

  1. And this is how it looks, when one today's event is in the past:

todays-colors-002-3-0-8

I agree that "Early morning errands" should be of past color. But is it correct to show today's Date header in today's color also in this case: before event, having past color? Looks like in the case 2 today's Date header should have Past color?!

yvolk commented 4 years ago
  1. It becomes even more interesting in the case 3 below: I added "Three days meeting with d" that started yesterday and will end tomorrow: todays-colors-003-3-0-8

Is everything on the right (v.1) correct? what we need to change now (on the left)?

PS: Why we don't see yesterday's part of the "Three days meeting with d" in both versions - is another story...

Clubby2010 commented 4 years ago

Yes, for me the v1 Version was correct in all cases. I wouldn't show today's header in past color,this would be strange in example 3. My default setting for showing past events is "ended today". In this,I would expect past events of today in the past color (yellow). Header, ongoing and future events of today in today's color (white).

yvolk commented 4 years ago

I made a fix. Will be published in v.3.0.9 todays-colors-004-3-0-9

yvolk commented 4 years ago

The fix is published in v.3.0.9 Beta, please check here: #320

Clubby2010 commented 4 years ago

I joined the google tester program,now it works,thank you