search

pluto / aes-circuits

Circom AES-GCM circuits
Apache License 2.0
27 stars 1 forks source link

tests: need to test gctr for two blocks #104

Closed 0xJepsen closed 5 days ago

0xJepsen commented 1 week ago

Right now we only have a good single block test for GCTR. I don't recall where we got the test case but it would really benefit us to have another test case for this spanning multiple blocks. I suspect we might not be incrementing the counter correctly.

https://github.com/pluto/aes-proof/blob/2d571a4eb63b9d80f4caa7640719d1f47ef34f97/circuits/test/aes-gcm/gctr.test.ts#L5-L22

0xJepsen commented 1 week ago

After we got end to end tests passing here this might no longer be needed.