feat(ciphers): AES encryption

pluto / ronkathon

Cryptography Educational Foundations

https://pluto.xyz/blog/ronkathon-learn-cryptography-from-first-principles

MIT License

134 stars 13 forks source link

feat(ciphers): AES encryption #102

Closed eightfilms closed 3 days ago

eightfilms commented 1 week ago

Partially addresses #95

It changes the following:

Adds an implementation of AES encryption using the SymmetricEncryption trait
note that decryption remains unimplemented - will add it as a follow up PR after this undergoes review and is merged

TODOs:

[x] doc comments where necessary
[x] richer readme like in other places
[x] cleanup code, debug statements, etc.

eightfilms commented 1 week ago

Going to rebase my work based on #101

eightfilms commented 6 days ago

Ok, I think this should be ready for a look. Preparing the docs took a bit longer than expected - let me know if anything is unclear

Autoparallel commented 6 days ago

Excited to review this. May not be able to until Sunday night or Monday.

eightfilms commented 4 days ago

Thanks for the reviews! Will implement decryption and an example of a slide attack within this same PR and request again very soon. Alternatively we can merge and leave that for a followup PR (whichever is preferable)

Autoparallel commented 4 days ago

@eightfilms I'm game to merge this and then handle a followup PR addressing our comments here.

Can you:

Make issues based off those comments
Resolve conflicts here?

Then I will merge :)

eightfilms commented 3 days ago

Oops, I messed up the commit history (i blame my unfamiliarity with jj), but all I really did was resolve the merge conflict. Sorry for the mess, i'll see if i can fix it

0xJepsen commented 3 days ago

Oops, I messed up the commit history (i blame my unfamiliarity with jj), but all I really did was resolve the merge conflict. Sorry for the mess, i'll see if i can fix it

I think it's okay! If thats all thats left we can git this one in

eightfilms commented 3 days ago

Yeah sounds good! Thanks @0xJepsen